Skip to content

fix: Move Review Committed toggle into section Show button - #243

Merged
Ziinc merged 2 commits into
mainfrom
cursor/review-committed-show-button-b67a
Aug 10, 2026
Merged

fix: Move Review Committed toggle into section Show button#243
Ziinc merged 2 commits into
mainfrom
cursor/review-committed-show-button-b67a

Conversation

@Ziinc

@Ziinc Ziinc commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Moves the Review tab's Committed eye toggle out of the top toolbar and into the Committed sidebar section header as a right-aligned Show button (eye / eye-off).

Behavior

  • Committed section header stays visible while Show is off, so the control remains available
  • Show toggles sidebar file rows and committed diffs; conflicted committed files still surface under Conflicts
  • Collapse (chevron) remains independent of Show
  • File count stays next to the Committed title; Show alone is pulled right

Test plan

  • Unit: CommittedChangesSection Show button + wiring tests
  • Integration: committed-dedup toggle + conflict-hidden via Show
  • Screenshot QA: review-committed-show-button + review-committed-conflict-hidden
  • Manual: open Review on a feature workspace and confirm no toolbar Committed button
Open in Web Open in Cursor 

cursoragent and others added 2 commits August 9, 2026 21:00
Relocate the Review-tab Committed eye toggle from the toolbar into the
Committed sidebar section header as a right-aligned Show control, and keep
the section available while committed diffs are hidden.

Co-authored-by: Ziinc <Ziinc@users.noreply.github.com>
Pull Show alone to the far right of the Committed header, keep the file
count with the title, and relocate section unit tests under src/ so vitest
picks them up. Add a screenshot spec for the new control.

Co-authored-by: Ziinc <Ziinc@users.noreply.github.com>
@cursor

cursor Bot commented Aug 9, 2026

Copy link
Copy Markdown

Why (key files)

  • CommittedChangesSection: Show lives on the header’s right so the toggle stays available after hiding; count stays with the title so Show is alone on the far edge.
  • useFileLoading / DiffContentArea: keep the full committed file list while Show is off, and only gate hunks/diff rows (conflicts still render).
  • ShowWorkspace: drop the Review toolbar Committed control; pass onShowCommittedChangesChange into the viewer instead.

@Ziinc
Ziinc marked this pull request as ready for review August 10, 2026 19:50
@Ziinc Ziinc changed the title Move Review Committed toggle into section Show button fix: Move Review Committed toggle into section Show button Aug 10, 2026
@Ziinc
Ziinc merged commit 70a591b into main Aug 10, 2026
11 of 13 checks passed
@Ziinc
Ziinc deleted the cursor/review-committed-show-button-b67a branch August 10, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants