Use LF line endings in selection text#8
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes selection text line separators to always use LF (\n) instead of StringBuilder.AppendLine(), avoiding platform-dependent CRLF insertion (notably on Windows) before host/clipboard normalization can be applied.
Changes:
- Updated
SelectionManager.GetSelectionText()to append'\n'between non-wrapped selected lines. - Added a unit test asserting selection text contains LF-only line endings and no carriage returns.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/XTerm.NET/Selection/SelectionManager.cs | Replaces AppendLine() with Append('\n') to ensure LF-only selection output. |
| src/XTerm.NET.Tests/SelectionTests.cs | Adds coverage to verify selection text uses LF line endings and excludes \r. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tomlm
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes terminal selection text use
\nas the internal line separator instead ofStringBuilder.AppendLine(), which emits platform-dependent line endings.On Windows,
AppendLine()produces CRLF before the host application or clipboard layer has a chance to apply its own platform normalization. Keeping XTerm.NET selection text LF-only gives host integrations one clear place to decide clipboard/export line-ending policy.Validation
dotnet test src\XTerm.NET.slnx