Skip to content

fix(memory/sync): send fetch_type in Notion NOTION_FETCH_DATA args #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YellowSnnowmann wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

fix(memory/sync): send fetch_type in Notion NOTION_FETCH_DATA args #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/memory/sync/composio/providers/notion.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ impl IncrementalSource for NotionSyncPipeline {
_: &SyncState,
page: Option<&str>,
) -> Value {
let mut args = serde_json::json!({"page_size": self.page_size, "filter": {"value": "page", "property": "object"}, "sort": {"direction": "descending", "timestamp": "last_edited_time"}});
let mut args = serde_json::json!({"fetch_type": "pages", "page_size": self.page_size, "filter": {"value": "page", "property": "object"}, "sort": {"direction": "descending", "timestamp": "last_edited_time"}});
if let Some(page) = page {
args["start_cursor"] = serde_json::json!(page);
}
Expand Down
3 changes: 3 additions & 0 deletions tests/composio_sync_mock.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,9 @@ async fn todoist_reingests_edited_task_without_timestamp_change() {
async fn notion_fetches_markdown_and_counts_both_requests() {
let server = MockServer::start().await;
Mock::given(path("/tools/execute/NOTION_FETCH_DATA"))
.and(body_partial_json(
serde_json::json!({"arguments": {"fetch_type": "pages"}}),
))
.respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({"successful": true, "data": {"results": [{"id": "page-1", "title": "Roadmap", "last_edited_time": "2026-03-01T00:00:00Z"}]}})))
.mount(&server).await;
Mock::given(path("/tools/execute/NOTION_GET_PAGE_MARKDOWN"))
Expand Down