v2/server/rack: negotiate the WebSocket subprotocol (RFC 6455)#27
Merged
Conversation
The v2 Rack opened the WebSocket without echoing a negotiated Sec-WebSocket-Protocol
(async path passed no `protocols:`; the threaded path omitted the header). The v1
handler always negotiated (`protocols: ['ws']`). Some edges/proxies (Fly) drop a
WebSocket whose offered subprotocol the server never echoes — the client then closes
before sending hello ("client closed before hello"). Echo the first subprotocol both
sides support (terminalwire.v2, else ws) on both the async and threaded paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2 Rack opened the WebSocket without echoing a negotiated
Sec-WebSocket-Protocol; the v1 handler always did (protocols: ['ws']). Edges/proxies like Fly drop a WS whose offered subprotocol the server never echoes — the client closes before hello. Echo the first mutually-supported subprotocol on both the async (Falcon) and threaded (Puma) paths. Gem specs 90/0.