Add runtime type information to worker heartbeats#809
Open
Sushisource wants to merge 1 commit into
Open
Conversation
10bd610 to
ed4d70d
Compare
Opengrep — new findings
Suppress findingsAdd a |
jmaeagle99
reviewed
Jun 19, 2026
| } | ||
|
|
||
| message RuntimeInfo { | ||
| enum RuntimeType { |
| } | ||
|
|
||
| message RuntimeInfo { | ||
| enum RuntimeType { |
Contributor
There was a problem hiding this comment.
I would also like to differentiate between .NET types e.g. Framework, Core, NativeAOT, etc and Unknown. So I think there should be a secondary field for this. It would be good to keep that it is .NET separate from the type of .NET in case we can't accurately identify it so we can still filter based on .NET and know we have a known gap.
Contributor
There was a problem hiding this comment.
Okay, I see we have an sdk_name field above. So maybe add DOTNET_FRAMEWORK and DOTNET_CORE.
02strich
reviewed
Jun 19, 2026
| RUNTIME_TYPE_BUN = 4; | ||
| RUNTIME_TYPE_RUBY = 5; | ||
| RUNTIME_TYPE_GO = 6; | ||
| RUNTIME_TYPE_DOCKER = 7; |
Contributor
There was a problem hiding this comment.
Is there more than one type possible? Like python in docker?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Title
Why?
Help us understand customer environments. SDKs will include an opt-out flag.
Breaking changes
Server PR