add GetWorkflowExecutionResult as a system nexus endpoint#781
Open
spkane31 wants to merge 15 commits into
Open
add GetWorkflowExecutionResult as a system nexus endpoint#781spkane31 wants to merge 15 commits into
spkane31 wants to merge 15 commits into
Conversation
spkane31
changed the title
spkane31
commented
May 22, 2026
spkane31
changed the title
bergundy
reviewed
Jun 17, 2026
Comment on lines
+38
to
+45
| option (google.api.http) = { | ||
| post: "/namespaces/{namespace}/workflows/{execution.workflow_id}/wait-for-external-workflow" | ||
| body: "*" | ||
| additional_bindings { | ||
| post: "/api/v1/namespaces/{namespace}/workflows/{execution.workflow_id}/wait-for-external-workflow" | ||
| body: "*" | ||
| } | ||
| }; |
Member
There was a problem hiding this comment.
I don't think we need HTTP for any of the system nexus APIs.
Comment on lines
+46
to
+50
| option (temporal.api.protometa.v1.request_header) = { | ||
| header: "temporal-resource-id" | ||
| value : "workflow:{execution.workflow_id}" | ||
| }; | ||
| } |
Member
There was a problem hiding this comment.
Need to understand how the SDK will use this later when we support direct calls for the system nexus endpoint. For now it doesn't give us any value to add this.
|
|
||
| - included_paths: | ||
| - "**/workflowservice/v1/service.proto" | ||
| - "**/workflownexusservice/v1/service.proto" |
Member
There was a problem hiding this comment.
Suggested change
| - "**/workflownexusservice/v1/service.proto" | |
| - "**/applicationservice/v1/service.proto" |
Comment on lines
+26
to
+27
| // The status of the workflow execution being waited on. This is needed to determine whether the workflow completed successfully or failed. | ||
| temporal.api.enums.v1.WorkflowExecutionStatus status = 1; |
Member
There was a problem hiding this comment.
Didn't we say we're not adding this?
| // (-- api-linter: core::0131::request-name-required=disabled --) | ||
| // (-- api-linter: core::0131::request-unknown-fields=disabled --) | ||
| message GetWorkflowExecutionResultRequest { | ||
| string namespace = 1; |
Member
There was a problem hiding this comment.
We said not to add this. It's always same namespace.
Comment on lines
+20
to
+21
| // The workflow execution to wait for. | ||
| temporal.api.common.v1.WorkflowExecution execution = 2; |
Member
There was a problem hiding this comment.
We should decide and then document what to do if run ID is provided. We may not be able to follow the runs in some cases and we would want a consistent experience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add the
GetWorkflowExecutionResultRPC and expose it as a system nexus operation.Why?
New API for workflows
Breaking changes
No breaking changes
Server PR
TBA