feat(validation): include error messages in ValidationFailed exception message#2203
Open
mgalexandre wants to merge 2 commits into
Open
feat(validation): include error messages in ValidationFailed exception message#2203mgalexandre wants to merge 2 commits into
mgalexandre wants to merge 2 commits into
Conversation
Member
|
I don't think this is the right thing to do, honestly. Appending the JSON-encoded message array seems rough around the edges. In what situations did you need the |
Author
|
I've reworked it to do two things:
|
Member
|
Right, didn't take a look at the original issue, thanks @mgalexandre @brendt, in what situations do you need the message to contain the actual errors? I do think the context, as suggested by Neo, is more suited here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Implements
ProvidesContext, exposing the errors as structured context, so they show up in log context viaLoggingExceptionReporterand on the development exception page, the same pattern asQueryWasInvalid,EncryptionFailed, andProcessExecutionWasForbidden.2. Appends the failures to the message in a human-readable format:
The message stays untouched (
Validation failed.) when there are no error messages.Fixes #2189