Name the tab lists for screen readers - #31111
Open
rezabakhshilaktasaraei wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complements #31097: that PR turns the painted sections of Ui::DiscreteSlider into an accessible list, but the list containers themselves had no accessible names, so a screen reader landing on them announced a bare "list". This PR names them at every call site - the chat list search tabs, the emoji / stickers / GIFs panel, the stickers box, the notifications count and proxy auto-switch sliders, the Stars transaction history, the channel earn history, the boosts list and the message options box.
Almost all names reuse existing keys near each slider (the subsection title or box context), so only one new key is added (lng_sr_message_options for the link / reply / forward options box, which has no single visible title when the tabs are shown). The folder tabs strip is not touched here - it is named in #31098.
Builds and runs fine without #31097 (an accessible name on a widget without an accessible role is simply unused), so there is no compile dependency, but the names only become audible together with it.