feat(pruner): add NetworkPolicy for controller and webhook - #3795
feat(pruner): add NetworkPolicy for controller and webhook#3795infernus01 wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
9e5eed7 to
d09b01e
Compare
d09b01e to
26953d8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3795 +/- ##
==========================================
- Coverage 25.40% 25.32% -0.08%
==========================================
Files 449 450 +1
Lines 23477 23555 +78
==========================================
+ Hits 5964 5966 +2
- Misses 16822 16897 +75
- Partials 691 692 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@infernus01 |
| type: string | ||
| type: object | ||
| type: array | ||
| required: |
There was a problem hiding this comment.
why this change ? can you rerun ./hack/update-codegen.sh/
|
@infernus01 Add Release note |
|
/kind misc |
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
26953d8 to
834246f
Compare
Changes
spec.networkPolicytoTektonPrunerapp.kubernetes.io/part-of: tekton-pruner), a controller allow policy (Prometheus metrics ingress on TCP/9090, unrestricted egress), and a webhook allow policy (admission callbacks on TCP/8443, Prometheus metrics on TCP/9090, unrestricted egress)spec.networkPolicyfromTektonConfig→TektonPruner, sodisabled: trueon TektonConfig removes polciespruner-network-policiesCustomSet on TektonPruner CR deletionEgress is unrestricted because the pruner controller needs API server access to list, watch, and delete PipelineRun/TaskRun resources across namespaces, and NetworkPolicy cannot select endpoints on the host network.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes
/kind feature