Skip to content

fix: out-of-range date error handle#1271

Open
IanChokS wants to merge 7 commits into
masterfrom
1265-date-execption
Open

fix: out-of-range date error handle#1271
IanChokS wants to merge 7 commits into
masterfrom
1265-date-execption

Conversation

@IanChokS

Copy link
Copy Markdown
Member

Fixes #1265

  • Add fix to properly throw error on invalid / out-of-range Date objects

@codecov

codecov Bot commented Jun 21, 2021

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.94%. Comparing base (57998f2) to head (3b6ec51).
⚠️ Report is 75 commits behind head on master.

Files with missing lines Patch % Lines
src/data-types/smalldatetime.ts 63.63% 2 Missing and 2 partials ⚠️
src/data-types/datetime.ts 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1271      +/-   ##
==========================================
- Coverage   79.00%   78.94%   -0.07%     
==========================================
  Files          93       93              
  Lines        4821     4839      +18     
  Branches      921      927       +6     
==========================================
+ Hits         3809     3820      +11     
- Misses        709      710       +1     
- Partials      303      309       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exception thrown from SmallDateTime/generateParameterData cannot be caught properly

3 participants