Skip to content

feat: test msnodesqlv8 against v2-v5 across supported Node versions #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhensby merged 1 commit into from
Jun 23, 2026
+27 −9
Merged

feat: test msnodesqlv8 against v2-v5 across supported Node versions #1870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,17 +145,35 @@ jobs:
run: npm run test-tedious
- name: Run cli tests
run: npm run test-cli
- name: Install msnodesqlv8
if: ${{ matrix.node != '22.x' && matrix.node != '24.x' }}
# msnodesqlv8 is exercised across its supported major versions. Each major
# is gated to the Node versions it ships prebuilt win32-x64 binaries for —
# a combo without a prebuild falls back to a node-gyp source build, which is
# brittle on the GitHub Windows images (e.g. the VS 2026 rollout on
# windows-2025 that node-gyp cannot detect). Coverage:
# v2: Node 18 v3: Node 18-20 v4: Node 18-24 v5: Node 20-24
- name: Install msnodesqlv8 v2
if: ${{ matrix.node == '18.x' }}
run: npm install --no-save msnodesqlv8@^2
- name: Run msnodesqlv8 tests
if: ${{ matrix.node != '22.x' && matrix.node != '24.x' }}
- name: Run msnodesqlv8 v2 tests
if: ${{ matrix.node == '18.x' }}
run: npm run test-msnodesqlv8
- name: Install msnodesqlv8
if: ${{ matrix.node == '22.x' || matrix.node == '24.x' }}
- name: Install msnodesqlv8 v3
if: ${{ matrix.node == '18.x' || matrix.node == '20.x' }}
run: npm install --no-save msnodesqlv8@^3
- name: Run msnodesqlv8 v3 tests
if: ${{ matrix.node == '18.x' || matrix.node == '20.x' }}
run: npm run test-msnodesqlv8
- name: Install msnodesqlv8 v4
if: ${{ matrix.node == '18.x' || matrix.node == '20.x' || matrix.node == '22.x' || matrix.node == '24.x' }}
run: npm install --no-save msnodesqlv8@^4
- name: Run msnodesqlv8 tests
if: ${{ matrix.node == '22.x' && matrix.node == '24.x' }}
- name: Run msnodesqlv8 v4 tests
if: ${{ matrix.node == '18.x' || matrix.node == '20.x' || matrix.node == '22.x' || matrix.node == '24.x' }}
run: npm run test-msnodesqlv8
Comment thread
dhensby marked this conversation as resolved.
- name: Install msnodesqlv8 v5
if: ${{ matrix.node == '20.x' || matrix.node == '22.x' || matrix.node == '24.x' }}
run: npm install --no-save msnodesqlv8@^5
- name: Run msnodesqlv8 v5 tests
if: ${{ matrix.node == '20.x' || matrix.node == '22.x' || matrix.node == '24.x' }}
run: npm run test-msnodesqlv8
release:
name: Release
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
Supported TDS drivers:

- [Tedious][tedious-url] (pure JavaScript - Windows/macOS/Linux, default)
- [MSNodeSQLv8][msnodesqlv8-url] (Microsoft / Contributors Node V8 Driver for Node.js for SQL Server, v2 native - Windows or Linux/macOS 64 bits only)
- [MSNodeSQLv8][msnodesqlv8-url] (Microsoft / Contributors Node V8 Driver for Node.js for SQL Server, v2-v5 native - Windows or Linux/macOS 64 bits only)

## Installation

Expand Down