Fix confirmout.json handling for missing/malformed files (#16)#96
Open
ba-00001 wants to merge 1 commit into
Open
Fix confirmout.json handling for missing/malformed files (#16)#96ba-00001 wants to merge 1 commit into
ba-00001 wants to merge 1 commit into
Conversation
The confirmout.json loader logged "JSON is in wrong format" whenever the file was simply absent, and would NPE if the file existed but failed to parse (the IOException was caught but rootDevNode was still dereferenced). Report a clear "not found" message when the file is missing, return early after a parse failure instead of dereferencing null, and extract the loading logic into a testable method. Add unit tests for the missing, null, malformed, and valid cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #16.
The original 'Could not load PropertiesLauncher' error is already resolved by the Spring Boot 3.5 upgrade (bootJar manifest and devicestarter.sh both use org.springframework.boot.loader.launch.PropertiesLauncher; verified present in the built jar).
This fixes the real remaining bug from the issue thread in DeviceErrorStatusResponse: