Use SimulatedDynamicDevice for MICR and line display simulators (#11)#95
Open
ba-00001 wants to merge 1 commit into
Open
Use SimulatedDynamicDevice for MICR and line display simulators (#11)#95ba-00001 wants to merge 1 commit into
ba-00001 wants to merge 1 commit into
Conversation
…et#11) MICR and line display were the only devices still wiring their simulators through the plain DynamicDevice and faking getClaimed() in the simulator to satisfy the connection check. Switch both to SimulatedDynamicDevice like the other devices and drop the now-unused getClaimed() overrides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11.
MICR and line display were the only devices still wiring their simulators through plain DynamicDevice, each faking getClaimed()=true in the simulator to satisfy the connection check. Switch both to SimulatedDynamicDevice like the other four devices and drop the now-unused getClaimed() overrides. Full suite passes; verified live in simulation (MICR and line display report READY).