Skip to content

de: Preserve whitespace for all nodes containg a text event - #897

Open
jamwil wants to merge 4 commits into
tafia:masterfrom
jamwil:space-issue
Open

de: Preserve whitespace for all nodes containg a text event#897
jamwil wants to merge 4 commits into
tafia:masterfrom
jamwil:space-issue

Conversation

@jamwil

@jamwil jamwil commented Aug 31, 2025

Copy link
Copy Markdown

Potential solution (or intermediate solution) to #896.

@jamwil
jamwil marked this pull request as ready for review August 31, 2025 14:22
@Mingun

Mingun commented Aug 31, 2025

Copy link
Copy Markdown
Collaborator

No, I think, this is bad decision. We already have poor designed make utility, where spaces handled differently than tabs and that counterintuitive. I think, the originally suggested implementation, which may be enabled by setting, would be better.

@jamwil

jamwil commented Aug 31, 2025

Copy link
Copy Markdown
Author

I'm fine with the original suggestion as it certainly will satisfy my requirements, I only propose this route as it accomplishes the same thing but is not destructive in the way you indicated. I do appreciate that broken but predictable is a better position to be in than using opinionated heuristics like this.

@jamwil jamwil changed the title de: Preserve whitespace for text events without a line break de: Preserve whitespace for all nodes containg a text event Aug 31, 2025
@jamwil

jamwil commented Aug 31, 2025

Copy link
Copy Markdown
Author

Updated as requested.

@jamwil

jamwil commented Sep 11, 2025

Copy link
Copy Markdown
Author

@Mingun I think I did this the way you described. Is there anything missing?

@Mingun

Mingun commented Sep 11, 2025

Copy link
Copy Markdown
Collaborator

Yes, the changes are mostly perfect, but I want to have configuration setting to enable them. I also want to make some small changes, which are easier to do myself than describe.

@dralley

dralley commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

@Mingun Do you plan to make those changes?

@dralley

dralley commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

If this is close to completion already, it would be nice to get it into the next release.

Along with (to whatever degree they are separate and not overlapping issues) #896 and #900 and #984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants