chore(test): retry in scan_skips_camped_returns_free to avoid TOCTOU flake#150
Merged
Merged
Conversation
…flake On macOS CI, other parallel tests' leaked HealthListeners can grab the `base+1` port between our probe-drop and the scan, causing the test to see `Found` instead of `FreePort`. Wrap the test body in a retry loop (up to 5 attempts) so a stolen port triggers a fresh port pair rather than a failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a flaky test failure on macOS CI:
scan_skips_camped_returns_freeintermittently fails withexpected FreePort, got Found(DaemonInfo { ... }).Root cause: TOCTOU race — the test drops the
base+1port probe, sleeps 50ms, then scans. During that window, another parallel test's leakedHealthListenercan bindbase+1and respond as a valid daemon.Fix: Wrap the test in a retry loop (up to 5 attempts). If the scan returns
Foundbecause another test stole the port, pick a fresh port pair and try again (optimistic concurrency).Test plan
cargo test -p hyperdb-mcp --test daemon_tests scan_skips_camped_returns_freepasses locally