feat(cli): Community add-ons no longer require scoped package names - #1216
feat(cli): Community add-ons no longer require scoped package names#1216sacrosanctic wants to merge 11 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/sv/c/d312d4b78cbdf04386e04f10573c04d21b866093Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: d312d4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| { | ||
| projectName: 'my-addon', | ||
| template: 'addon', | ||
| args: [] | ||
| } |
There was a problem hiding this comment.
Do we need a test for this? (Right now, CI is failing probably because snapshots are missing).
I think that having 1 test for addon is ok (if it's only the name update)
| @@ -0,0 +1,32 @@ | |||
| // https://npmx.dev/package/validate-npm-package-name#user-content-naming-rules | |||
| export const validateProjectName = (value: string | undefined): string | undefined => { | |||
There was a problem hiding this comment.
This validation of package name is not really belonging to this PR (tests as well)
|
Here we would need to adjust docs & a changeset (patch) as it's a significative change. |
sacrosanctic
changed the title
|
Somebody with a bigger computer update the snapshots. |
2 participants
Closes #1101
Description
It currently accepts
@<org>,<pkg>, and@<org>/<pkg>. Also went a little overboard with the name validation. We can pare it down.Checklist