feat(cli): nextSteps handle falsy values

[sacrosanctic]

Closes #

Description

• QoL change, falsy values are nicer to work with

Checklist

• Update snapshots (if applicable)
• Add a changeset (if applicable)
• Allow maintainers to edit this PR
• I care about what I'm doing, no matter the tool I use (Notepad, Sublime, VSCode, AI...)

[pkg-svelte-dev]

Install the latest version of sv from da4aac5:

pnpm add https://pkg.svelte.dev/sv/c/da4aac5bb0758801cdc1c21d05d1ea7687850fc7

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/cli/pr/1215

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

[changeset-bot]

🦋 Changeset detected

Latest commit: da4aac5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
sv	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[jycouet]

falsy values are nicer to work with

Yes?! I find them a bit more cryptic! I don't have a huge opinion on this. Maybe others wanna have a look?

I'll have to see why svelte.dev is not happy for cli, that's annoying.

[AdrianGonz97]

Yea, I agree with @jycouet on this one. I don't think allowing falsy values and filtering them out is a great improvement on clarity.

[AdrianGonz97]

this helper is a nice addition though. we could keep that

[jycouet]

Online here ? Or even higher ? To be used in other spots ? 👀

[GauBen]

Yes?! I find them a bit more cryptic! I don't have a huge opinion on this. Maybe others wanna have a look?

I don't have a strong opinion on this, but

nextSteps: ({ isKit, packageManager }) =>
  [
    isKit && `Run ${color.command(resolveCommandArray(packageManager, "run", ["dev"]))} and consult ${color.website("http://localhost:5173/demo/markdown")} to see the result`,
    `Read the documentation at ${color.website("https://github.com/ota-meshi/vite-plugin-svelte-md")}`,
  ],

is a bit nicer than

nextSteps: ({ isKit, packageManager }) =>
  [
    `Run ${color.command(resolveCommandArray(packageManager, "run", ["dev"]))} and consult ${color.website("http://localhost:5173/demo/markdown")} to see the result`,
    `Read the documentation at ${color.website("https://github.com/ota-meshi/vite-plugin-svelte-md")}`,
  ].slice(isKit ? 0 : 1),

(From ota-meshi/vite-plugin-svelte-md#157)

[AdrianGonz97]

I mean, if people really want it, nothing stops them from just filtering out the falsy values themselves:

nextSteps: ({ isKit, packageManager }) =>
  [
    isKit && "...stuff 1",
	isKit && "...more stuff 2",
	isKit && packageManager === "pnpm" && "...even more stuff 3",
    "...always added stuff 4",
  ].filter(Boolean),

[sacrosanctic]

@AdrianGonz97 typescript does not resolve that correctly. microsoft/TypeScript#16655

You'd need to do this

nextSteps: ({ isKit, packageManager }) => {
  const notNullable = (x:any):x is NonNullable<typeof x> => Boolean(x)

  return [
    isKit && "...stuff 1",
    isKit && "...more stuff 2",
    isKit && packageManager === "pnpm" && "...even more stuff 3",
    "...always added stuff 4",
  ].filter(notNullable)
}

[AdrianGonz97]

right, a bit more verbose to satisfy typescript then:

  nextSteps: ({ isKit, packageManager }) => [
      isKit && "...stuff 1",
      isKit && "...more stuff 2",
      isKit && packageManager === "pnpm" && "...even more stuff 3",
      "...always added stuff 4",
  ].filter((line): line is string => !!line),

annoying but still doable