fix(ext/node): return errors instead of panicking in ECDH ops - #714
Merged
Conversation
`op_node_ecdh_compute_secret` and `op_node_ecdh_compute_public_key` panicked via `.expect()` on malformed keys and `todo!()` on unknown curves, taking down the runtime on user-supplied input. Both ops now return a new `EcdhError`, which is mapped to `TypeError` for JS. Ref: denoland/deno#33751 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
nyannyacha
changed the title
kallebysantos
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
op_node_ecdh_compute_secretandop_node_ecdh_compute_public_keypanicked via
.expect()on malformed keys andtodo!()on unknowncurves, taking down the runtime on user-supplied input. Both ops now
return a new
EcdhError, which is mapped toTypeErrorfor JS.Ref: denoland/deno#33751
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com