Enable viscous flux contribution at supersonic outlet boundary condition

[yiluntam]

Proposed Changes

The viscous flux contribution in BC_Supersonic_Outlet was previously commented out due to reported convergence issues. However, for viscous NS simulations this omission is physically incorrect and causes severe convergence problems at outlet boundary cells, which also prevents the use of second-order MUSCL reconstruction.

For supersonic flows, downstream disturbances cannot propagate upstream, so the outlet state can be safely extrapolated from the domain interior. Using SetPrimitive(V_domain, V_domain) instead of (V_domain, V_outlet) resolves the convergence problems that motivated the original commenting.

PR Checklist

• [ x ] I am submitting my contribution to the develop branch.
• [ x ] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
• My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
• I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
• I have added a test case that demonstrates my contribution, if necessary.
• I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

[yiluntam]

@pcarruscag Could you take a look at this when you have time? Thanks!

[yiluntam]

Validation: Ma = 4, Tw/T∞ = 1, laminar flat plate boundary layer. Cf distribution agrees well with Anderson's hypersonic reference ("Hypersonic and High Temperature Gas Dynamics").

As can be seen, the new code aligns more closely with the theoretical solution. The distribution of physical quantities at the outlet is also more reasonable. Furthermore, the convergence time required during the calculation has been reduced.

[yiluntam]

It looks like I left out a line of code, since I had been using version 8.0.1 all along. The code has now compiled successfully. Sorry for uploading the incorrect code earlier. @bigfooted @pcarruscag

[bigfooted]

Hi, can you add a figure of the residual plot of before and after here, and can you add your testcase to the PR? It looks like none of the existing testcases are using this.
You can add the .cfg file to this repository inside of the Testcases subdirectory.

[yiluntam]

Here is a comparison of the convergence residual history before and after the code modification. It seems there was a slight inaccuracy in my previous description. It would be more accurate to say that the convergence does not diverge, rather than that it converges faster. Additionally, the .cfg and .cgns files have been placed in the Testcases subdirectory.

[bigfooted]

Hi @yiluntam,

The meshes go into our separate Testcases repository, https://github.com/su2code/TestCases
Can you create a second Pull Request and add the mesh to this repository instead? Please remove it from this PR. Also rename the cgns flatplate_supersonic.cgns for clarity. It can be placed into the existing subdirectory navierstokes/flatplate

Please add the .cfg file to the existing subdirectory navierstokes/flatplate/ in this PR.
We already have some files there, so please rename it to flatplate_supersonic.cfg

Then finally, you can add this case as a new regression case to TestCases/parallel_regression.py
You can just copy-paste the existing block for flatplate and call it flatplate_supersonic. Just leave the existing residual values for now, they can be updated after the tests ran here on github.