Fix note admonition and linked inline-code contrast/consistency - #3371
Open
annakudelska wants to merge 1 commit into
Open
Fix note admonition and linked inline-code contrast/consistency#3371annakudelska wants to merge 1 commit into
annakudelska wants to merge 1 commit into
Conversation
- note admonition: rework background/border/inline-code colors in both light and dark mode so text meets WCAG AA (4.5:1) against their backgrounds - all inline code wrapped in a link: prepend a link icon (Phosphor), reduce font-weight from bold to regular, and normalize the border width to 1px to match admonition borders (previously 1.6px via Infima's default)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the contrast/readability pass on the redesigned components (see the design showcase preview). This PR covers the
note(blue) admonition and a couple of site-wide inline-code fixes; thecaution/dangervariants are still under discussion with design and will follow in a separate PR.noteadmonition (light + dark): reworked background, border, and inline-code colors so text meets WCAG AA (4.5:1) against their actual backgrounds. Verified contrast ratios:[text with `code`](url), any context/variant): prepend a link icon (Phosphorph-link, inheritscurrentColorso it matches every admonition variant and both themes automatically), reduce font-weight from bold to regular, and normalize border width to1px(previously0.1rem/1.6px via Infima's default) to match the1pxadmonition border.Test plan
yarn buildpasses locally (client + server compiled successfully)notetext/background pairs (see above)🤖 Generated with Claude Code