Verify target withdrawal address matches the vault in consolidations - #807
Open
cyc60 wants to merge 1 commit into
Open
Verify target withdrawal address matches the vault in consolidations#807cyc60 wants to merge 1 commit into
cyc60 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consolidation sources are checked for a vault-matching withdrawal address, but plain-consolidation targets were not. The consensus layer silently ignores a consolidation whose source withdrawal address does not match the request, while a consolidation into a target with foreign withdrawal credentials is executed — moving the sources' balance into a validator the vault cannot withdraw from.
ConsolidationSelector._find_validators_candidates: exclude validators whose withdrawal address does not match the vault from target candidacy (the check now covers both source and target roles).ConsolidationChecker._validate_target_validator: reject a plain-consolidation target whose withdrawal address does not match the vault, consistent with the existing source check.