Cover Dict typed getters and Reader resolve helpers#18
Merged
Conversation
Add object_test.go exercising every Dict accessor on one fixture: success values, reference resolution via Dict(), nil-receiver safety, and the type-mismatch paths that must report ok=false. Add Reader.ResolveInt/ Bool/Array tests (including mismatch errors), Trailer access, and the catalog /Version override. object.go Len/Has/Keys/Bool/Bytes and reader.go Trailer/Version to 100%; ResolveInt/Bool/Array 0% -> 85.7%.
fank
force-pushed
the
claude/accessor-coverage
branch
from
4e439a8 to
5ea9d44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers the public accessor API, which was largely untested.
Tests
TestDictAccessors— one fixture exercisesInt/Bool/String/Bytes/Name/Array/Dictsuccess values, reference resolution throughDict(),Has/Keys/Len/Iter, and every type-mismatch path (which must reportok=false, not coerce or panic).TestDictNilReceiver— all accessors are safe on a nil*Dict(the common "key absent" result).TestResolveHelpers—Reader.ResolveInt/ResolveBool/ResolveArrayagainst indirect references, including type-mismatch errors, plusTrailer().TestVersionCatalogOverride— a catalog/Versionhigher than the header wins.No production code changed. Coverage:
Len/Has/Keys/Bool/Bytes/Trailer/Version→ 100%;ResolveInt/Bool/Array0% → 85.7%.Deliberately left:
Stream-success andRawLength(one-line getters not worth a contrived stream fixture).