Cover encryption param parsing (crypt)#17
Merged
Conversation
encryptParamsFromDict and initEncrypt were only exercised for the V2/R3 RC4 case. Add coverage at the Open() surface: - a V4/R4 fixture using a /CF StdCF crypt filter (CFM /V2), decrypting a stream end-to-end through the /CF + /StmF parsing path; - rejection of a non-Standard security handler; - a malformed-/Encrypt sweep (wrong type, missing /V and /R, short O/U, short V5 OE/UE/Perms) that must error, never panic. Factor the shared PDF assembly out of buildRC4EncryptedStreamPDF so the V2 and V4 builders reuse it. initEncrypt 78.9% -> 89.5%; encryptParamsFromDict 65.9% -> 95.1%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encryptParamsFromDict(65.9%) andinitEncrypt(78.9%) were only exercised for the V2/R3 RC4 path. This adds coverage of the untested seams, all at theOpen()surface.Tests
TestOpenDecryptsV4RC4Stream— a V4/R4 fixture whoseStdCFcrypt filter usesCFM /V2(RC4, same empty-password key derivation as V2/R3). Decrypts a stream end-to-end through the/CF+/StmFparsing path that V2 doesn't touch.TestEncryptNonStandardFilterRejected—/Filter /FooSecuritymust error, not be treated as unencrypted.TestEncryptMalformedNoPanic—/Encryptthat is the wrong type, missing/Vand/R, has short/O+/U, or short V5/OE//UE//Permsmust all error gracefully (and the V5 case exercises those param assignments).Refactor
Shared PDF assembly extracted from
buildRC4EncryptedStreamPDFintoassembleEncryptedPDF, reused by both the V2 and new V4 builders.No production code changed. Coverage:
initEncrypt78.9% → 89.5%;encryptParamsFromDict65.9% → 95.1%.