Fix Allow any valid user access to public Dataset through SDK - #335
Open
mjcurran wants to merge 9 commits into
Open
Fix Allow any valid user access to public Dataset through SDK#335mjcurran wants to merge 9 commits into
mjcurran wants to merge 9 commits into
Conversation
lucaspar
approved these changes
Aug 21, 2026
lucaspar
left a comment
Member
There was a problem hiding this comment.
Thanks. It'd be good to add some regression tests to make sure this keeps working in the future.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 09f09f4. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

SFDS-320
Fix permission issues trying to access assets of public datasets
Note
Medium Risk
Changes authorization rules for datasets, captures, and files; incorrect
is_publichandling could expose or over-restrict assets, though scope is limited to the intended public flag.Overview
Fixes SDK and API access for public datasets, captures, and linked files when there is no explicit
UserSharePermissionrow.Permission model:
UserSharePermission.get_user_permission_levelnow returns viewer for any authenticated check path when the target dataset or capture hasis_public=True(and is not deleted), after owner and explicit share checks fail.Access control utilities:
user_has_access_to_capture,user_has_access_to_file, and theget_accessible_*_querysethelpers treatis_publiclike an implicit grant— including nested paths (files on public captures, files on captures in public datasets, files linked to public datasets, and directly public files).Tests: Adds coverage that an unshared user sees public M2M-linked files and captures in the accessible querysets.
Reviewed by Cursor Bugbot for commit 5ad9ea1. Bugbot is set up for automated code reviews on this repo. Configure here.