fix: remove with-tanstack-router in v2#80
Merged
Tommypop2 merged 1 commit intoJul 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remove
with-tanstack-routerfrom the v2 template list.In commit 64a6011,
with-tanstack-routerwas mistakenly removed from the v1 list instead of v2.This PR corrects it by removing
with-tanstack-routerfrom the v2 list.Details
Once routerLoad is restored in the upcoming release of
solid-start, with-tanstack-router is expected to work properly again.You can either wait for the next release before merging
Or remove it now and re-add it once
with-tanstack-routeris updated to function properly.p.s. Sorry for any confusion or hassle caused!😅