Skip to content

refactor: migrate member_ordering rule#297

Open
solid-illiaaihistov wants to merge 1 commit into
solid-software:analysis_server_migrationfrom
solid-illiaaihistov:252-migrate-member_ordering
Open

refactor: migrate member_ordering rule#297
solid-illiaaihistov wants to merge 1 commit into
solid-software:analysis_server_migrationfrom
solid-illiaaihistov:252-migrate-member_ordering

Conversation

@solid-illiaaihistov

Copy link
Copy Markdown
Collaborator

Closes #252

@solid-illiaaihistov

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the member_ordering lint rule to extend SolidMultiLintRule (a new base class for rules with multiple diagnostic codes), splits several model classes into separate files, and replaces the old test file with a comprehensive unit test suite. The review feedback correctly identifies two critical compilation errors in MemberOrderingVisitor: first, the use of the non-existent BlockClassBody class, and second, attempting to access a .name property on ConstructorDeclaration.typeName (which is a Token and should use .lexeme instead).

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/src/lints/member_ordering/visitors/member_ordering_visitor.dart
Comment thread lib/src/lints/member_ordering/visitors/member_ordering_visitor.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant