π μ§μ λν κ΄λ¦¬ κ²μ μ κ΅λ΄ λν/νκΈ° νν° λ―Έμ μ© λ²κ·Έ μμ - #617
Conversation
searchUnivApplyInfosκ° κ²μμ΄λ§ μλ²λ‘ 보λ΄κ³ homeUniversityId/termIdλ₯Ό μ λ¬νμ§ μμ, μλ²κ° νμ νμ¬ νκΈ° κΈ°μ€μΌλ‘ μλ΅νλ€. μλ΅μ λ€μ μ νν νκΈ° λΌλ²¨κ³Ό λΉκ΅ν΄ ν΄λΌμ΄μΈνΈμμ νν°λ§νλ λ‘μ§ λλ¬Έμ νμ¬ νκΈ°κ° μλ νκΈ°λ₯Ό μ ννλ©΄ κ²°κ³Όκ° μμ΄λ νλ©΄μλ μ무κ²λ νμλμ§ μμλ€. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EwpgqdNTrn8dGDr7g7WnYg
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Walkthrough
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: π₯ Pre-merge checks | β 4 | β 1β Failed checks (1 warning)
β Passed checks (4 passed)
β¨ Finishing Touches π‘ 1π Generate docstrings π‘
π§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
π§Ή Nitpick comments (1)
apps/admin/src/lib/api/admin.ts (1)
373-380: ποΈ Data Integrity & Integration | π΅ Trivial | β‘ Quick win1. μΈ κ²μ 쑰건μ μ λ¬μ νκ· ν μ€νΈλ‘ κ³ μ ν΄ μ£ΌμΈμ.
searchUnivApplyInfosμ κ³μ½μ΄valueλ¨μΌ κ°μμ μΈ νλλ‘ λ³κ²½λμμ΅λλ€.apps/admin/src/lib/api/admin.test.tsμvalue,homeUniversityId,termIdκ°/univ-apply-infos/search/textμparamsμ λͺ¨λ μ λ¬λλμ§ νμΈνλ ν μ€νΈλ₯Ό μΆκ°ν΄ μ£ΌμΈμ. ν₯ν νν° λλ½ νκ·λ₯Ό λΉ λ₯΄κ² λ°κ²¬ν μ μμ΅λλ€.π€ Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/admin/src/lib/api/admin.ts` around lines 373 - 380, In the admin API tests, add a regression test for searchUnivApplyInfos that invokes it with value, homeUniversityId, and termId, then verifies the GET request to "/univ-apply-infos/search/text" includes all three fields in params.
π€ Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@apps/admin/src/lib/api/admin.ts`:
- Around line 373-380: In the admin API tests, add a regression test for
searchUnivApplyInfos that invokes it with value, homeUniversityId, and termId,
then verifies the GET request to "/univ-apply-infos/search/text" includes all
three fields in params.
βΉοΈ Review info
βοΈ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 817888a8-76a9-4576-97c1-90d6cc45156d
π Files selected for processing (2)
apps/admin/src/components/features/univ-apply-infos/tabs/UnivApplyInfoManageTab.tsxapps/admin/src/lib/api/admin.ts
μμ½
adminApi.searchUnivApplyInfosκ° κ²μμ΄(value)λ§ μλ²λ‘ μ μ‘νκ³homeUniversityId/termIdλ 보λ΄μ§ μμ, μλ²κ° νμ νμ¬ νκΈ° κΈ°μ€μΌλ‘λ§ μλ΅νκ³ μμμhomeUniversityId/termIdλ₯Ό μ€μ λ‘ μλ²μ μ λ¬νλλ‘ μμ νκ³ , μλ²κ° μ΄λ―Έ νν°λ§νλ―λ‘ λΆνμν΄μ§ ν΄λΌμ΄μΈνΈ μΈ‘ μ¬νν°λ§ λ‘μ§ μ κ±°ν μ€νΈ νλ
pnpm --filter admin typecheck,lint:checkν΅κ³Ό (μ»€λ° μ CI parity ν μΌλ‘ νμΈ)Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
https://claude.ai/code/session_01EwpgqdNTrn8dGDr7g7WnYg