feat: 지원 대학 단건 조회 API 추가 - #818
Merged
Merged
Conversation
어드민 지원 대학 관리에서 수정 모달을 열 때 목록 조회(search/text)
응답만 사용하고 있어 정원 외 필드가 채워지지 않는 문제가 있었다.
search/text가 반환하는 미리보기 응답에는 애초에 해당 필드들이
포함되어 있지 않아 프론트에서 해결할 수 없었다.
GET /admin/univ-apply-infos/{id}를 추가해 전체 필드를 담은
AdminUnivApplyInfoResponse를 단건으로 조회할 수 있게 했다.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EwpgqdNTrn8dGDr7g7WnYg
WalkthroughEstimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/test/java/com/example/solidconnection/admin/university/service/AdminUnivApplyInfoServiceTest.java (1)
521-543: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win1. 전체 필드 응답 계약을 검증하세요.
이 테스트는
koreanName,semesterAvailableForDispatch,extraInfo,languageRequirements를 검증하지 않습니다.이 필드는 단건 상세 조회 API의 핵심 계약입니다. Fixture에 각 값을 명시적으로 설정하고 응답값을 검증하세요.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/test/java/com/example/solidconnection/admin/university/service/AdminUnivApplyInfoServiceTest.java` around lines 521 - 543, Update 존재하는_id로_조회하면_상세_정보를_반환한다() to explicitly set koreanName, semesterAvailableForDispatch, extraInfo, and languageRequirements on the UnivApplyInfo fixture, then add assertions that the response returns each configured value through the corresponding AdminUnivApplyInfoResponse accessors.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@src/test/java/com/example/solidconnection/admin/university/service/AdminUnivApplyInfoServiceTest.java`:
- Around line 521-543: Update 존재하는_id로_조회하면_상세_정보를_반환한다() to explicitly set
koreanName, semesterAvailableForDispatch, extraInfo, and languageRequirements on
the UnivApplyInfo fixture, then add assertions that the response returns each
configured value through the corresponding AdminUnivApplyInfoResponse accessors.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 8d294572-3240-4db9-83df-b17402f4112f
📒 Files selected for processing (3)
src/main/java/com/example/solidconnection/admin/university/controller/AdminUnivApplyInfoController.javasrc/main/java/com/example/solidconnection/admin/university/service/AdminUnivApplyInfoService.javasrc/test/java/com/example/solidconnection/admin/university/service/AdminUnivApplyInfoServiceTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
GET /admin/univ-apply-infos/{id}를 추가해 전체 필드를 담은
AdminUnivApplyInfoResponse를 단건으로 조회할 수 있게 구현했습니다
특이 사항
리뷰 요구사항 (선택)