Conversation
* feat: 지원 현황 미리보기 API 추가 * fix: 지원 현황 미리보기를 모교별로 제한 * fix: 지원 현황 미리보기 리뷰 반영
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 065564c8fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| set +e | ||
| REPEAT_COUNT="${{ github.event.inputs.repeat_count }}" | ||
| FAIL_COUNT=0 | ||
| for i in $(seq 1 "$REPEAT_COUNT"); do |
There was a problem hiding this comment.
When a dispatcher supplies 0, a negative value, a fractional value, or malformed text, this loop may execute fewer tests than requested—or none at all—while the preceding set +e ignores seq errors and leaves FAIL_COUNT at zero, producing a successful workflow without the intended test coverage. GNU seq --help confirms that arguments are interpreted as floating-point values and that a default positive sequence below its first value emits nothing; validate REPEAT_COUNT as a positive integer before entering the loop.
Useful? React with 👍 / 👎.
어드민 지원 대학 관리에서 수정 모달을 열 때 목록 조회(search/text)
응답만 사용하고 있어 정원 외 필드가 채워지지 않는 문제가 있었다.
search/text가 반환하는 미리보기 응답에는 애초에 해당 필드들이
포함되어 있지 않아 프론트에서 해결할 수 없었다.
GET /admin/univ-apply-infos/{id}를 추가해 전체 필드를 담은
AdminUnivApplyInfoResponse를 단건으로 조회할 수 있게 했다.
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
2 participants
No description provided.