feat(deployments): add v1 deployment endpoints and Deployments block#5009
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview Introduces a Deployments core block and five internal tool routes under Sim trigger gains Workflow Undeployed ( Reviewed by Cursor Bugbot for commit 1543da4. Configure here. |
Greptile SummaryThis PR adds three v1 API endpoints and a new Deployments core block with five operations. All surfaces funnel through shared orchestration helpers, and a new
Confidence Score: 5/5Safe to merge. All three previously flagged issues have been addressed in c0d450a. Auth separation between the v1 and tool surfaces is correct and tested. The new endpoints and block are well-structured. Workspace binding, permission checks, and the isDeployed guard are all in place. 31 new route tests cover the key paths. No files require special attention. The two observations are minor style notes on the Deployments block config callbacks. Important Files Changed
Reviews (5): Last reviewed commit: "feat(deployments): resolve workflow name..." | Re-trigger Greptile |
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c0d450a. Configure here.
…arnings, guard orphaned workspaceId
… version bounds, and 404 masking - Tool routes now require the executing workspace ID and reject cross-workspace targets - v1 deploy/rollback read optional bodies via parseOptionalJsonBody (size-capped, 400 on malformed JSON) - Version numbers bounded to the Postgres integer range - v1 mutation routes mask access failures as 404, matching the v1 detail route - listWorkflowVersions returns description and normalizes admin-api deployedByName (parity with mothership get_deployment_log) - Workflow selector no longer auto-selects the first workflow (new autoSelectFirstOption opt-out) - Shared deployment version metadata field schemas across UI/v1/tool contracts
c0d450a to
94870e2
Compare
|
Pushed a hardening round from a full line-by-line audit (5 parallel reviewers) plus a rebase onto latest staging:
|
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 94870e2. Configure here.
Workflow, workspace, folder, knowledge-base, document, and execution IDs are plain UUIDv4; workspace file IDs are wf_<shortId>; table and row IDs are tbl_/row_ + de-dashed UUID. Replaces all fake prefixed example IDs (wf_abc123, ws_xyz789, exec_..., kb_..., etc.) accordingly and marks the deploy body description as nullable to match the shared schema.
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 079b6a6. Configure here.
…ndeployed Sim trigger event - Deployments block now uses the workflow-selector subblock (same as the Workflow block), so the canvas tile shows the workflow name instead of the raw ID; reverts the now-unneeded dropdown autoSelectFirstOption prop - Adds workflow_undeployed to the Sim workspace-event trigger, emitted by performFullUndeploy through a shared lifecycle-event dispatch loop
|
Final round pushed (1543da4):
|
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1543da4. Configure here.
Summary
POST /api/v1/workflows/{id}/deploy,DELETE /api/v1/workflows/{id}/deploy, andPOST /api/v1/workflows/{id}/rollback(defaults to the previous version, accepts an explicitversion)/api/tools/deployments/*routes authenticated via session or internal token (no API key needed)performFullDeploy,performFullUndeploy,performActivateVersion)Type of Change
Testing
check:api-validation:strict, and docs build passChecklist