Skip to content

Improve General tab guidance and move custom domain to Advanced.#35

Merged
adriaandotcom merged 3 commits into
simpleanalytics:mainfrom
paulber33:fix-issue-18-general-tab
Jun 18, 2026
Merged

Improve General tab guidance and move custom domain to Advanced.#35
adriaandotcom merged 3 commits into
simpleanalytics:mainfrom
paulber33:fix-issue-18-general-tab

Conversation

@paulber33

Copy link
Copy Markdown
Contributor

This reduces setup confusion by keeping custom domain under Advanced, adds clearer onboarding copy and dashboard links in General, hides Save Changes on that informational tab, and updates browser tests for the revised tab behavior.

Summary

Closes #18

Moved the Custom Domain setting from the General tab to the Advanced tab to prevent accidental misconfiguration. Added onboarding content and dashboard/signup links to the General tab, updated the header dashboard link URL, and hid Save Changes on the informational General tab.

image

Security implications

  • No security impact
  • Has security impact - described as:

Testing

Validated with focused Playwright browser tests:

  • adds a script by default
  • shows guidance on general tab and keeps custom domain in advanced tab
  • adds a script with a custom domain name

Also ran php -l for the updated UI PHP file.

Checklist

  • Linked to an issue
  • Tested
  • Asked for a review

This reduces setup confusion by keeping custom domain under Advanced, adds clearer onboarding copy and dashboard links in General, hides Save Changes on that informational tab, and updates browser tests for the revised tab behavior.

@adriaandotcom adriaandotcom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, some copy changes.

Comment thread src/UI/PageLayoutComponent.php Outdated
Comment on lines +177 to +179
<a class="text-primary hover:underline" target="_blank" href="<?php echo esc_url(self::SIGNUP_URL); ?>">
simpleanalytics.com
</a>.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevents a space between link and dot:

Suggested change
<a class="text-primary hover:underline" target="_blank" href="<?php echo esc_url(self::SIGNUP_URL); ?>">
simpleanalytics.com
</a>.
<a class="text-primary hover:underline" target="_blank" href="<?php echo esc_url(self::SIGNUP_URL); ?>">simpleanalytics.com</a>.

Comment thread src/UI/PageLayoutComponent.php Outdated
Comment on lines +160 to +165
This plugin adds Simple Analytics to your WordPress site and collects pageviews in a privacy-first way.
Your stats appear in
<a class="text-primary hover:underline" target="_blank" href="<?php echo esc_url(self::DASHBOARD_URL); ?>">
your dashboard
</a>
within minutes.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some people expect the dashboard within Wordpress, so this makes it more clear:

Suggested change
This plugin adds Simple Analytics to your WordPress site and collects pageviews in a privacy-first way.
Your stats appear in
<a class="text-primary hover:underline" target="_blank" href="<?php echo esc_url(self::DASHBOARD_URL); ?>">
your dashboard
</a>
within minutes.
The plugin collects pageviews in a privacy-first way, without cookies or personal data.
Your stats will appear in
<a class="text-primary hover:underline" target="_blank" href="<?php echo esc_url(self::DASHBOARD_URL); ?>">
the Simple Analytics dashboard
</a>
within a few minutes.

Comment thread src/UI/PageLayoutComponent.php Outdated
?>
<div class="mb-7" style="max-width: 64ch;">
<p class="text-sm text-gray-700">
Thanks for choosing Simple Analytics.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Thanks for choosing Simple Analytics.
Simple Analytics is now added to your WordPress site.

Comment thread src/UI/PageLayoutComponent.php Outdated
Comment on lines +168 to +169
To exclude your own visits, open the "Ignore Rules" tab and enable the option for logged-in admins.
You can also add your own IP there.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To exclude your own visits, open the "Ignore Rules" tab and enable the option for logged-in admins.
You can also add your own IP there.
To avoid tracking your own visits, go to the "Ignore Rules" tab and ignore visits from logged-in admins.
You can also add your own IP address there.

Comment thread src/UI/PageLayoutComponent.php Outdated
Comment on lines +172 to +173
Want automated events, like downloads, outbound link clicks, and email clicks, collected for you,
check "Collect automated events" in the "Events" tab.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Want automated events, like downloads, outbound link clicks, and email clicks, collected for you,
check "Collect automated events" in the "Events" tab.
To automatically track downloads, outbound links, and email clicks, go to the "Events" tab and enable "Collect automated events".

Comment thread src/UI/PageLayoutComponent.php Outdated
check "Collect automated events" in the "Events" tab.
</p>
<p class="mt-4 text-sm text-gray-700">
No account yet? Sign up at

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
No account yet? Sign up at
No account yet? Create one at

Comment thread src/UI/PageLayoutComponent.php Outdated
<a class="text-primary hover:underline" target="_blank" href="<?php echo esc_url(self::SIGNUP_URL); ?>">
simpleanalytics.com
</a>.
The trial includes almost all features, then you can choose a free or paid plan.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The trial includes almost all features, then you can choose a free or paid plan.
You can start with a free trial and choose a free or paid plan later.

Comment thread src/UI/PageLayoutComponent.php Outdated
target="_blank"
class="inline-flex items-center rounded bg-primary px-3 py-2 text-sm font-semibold text-white shadow-sm hover:bg-red-500"
>
Visit your analytics dashboard

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Visit your analytics dashboard
Open dashboard

@paulber33 paulber33 requested a review from adriaandotcom June 18, 2026 13:00
@adriaandotcom adriaandotcom merged commit f5a97b3 into simpleanalytics:main Jun 18, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update General tab to prevent confusion

2 participants