Fix missing REMOTE_ADDR fallback in tracking rules.#33
Merged
adriaandotcom merged 1 commit intoJun 18, 2026
Merged
Conversation
Prevent undefined array key warnings by safely defaulting to null. Co-authored-by: Cursor <cursoragent@cursor.com>
adriaandotcom
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent undefined array key warnings by safely defaulting to null.
Summary
Closes #19
Updates the excluded IP tracking rule so
REMOTE_ADDRsafely falls back tonullwhen neitherHTTP_X_FORWARDED_FORnorREMOTE_ADDRis available. This prevents PHP undefined array key warnings while preserving the existing behavior of returningfalsewhen no IP address is present.Security implications
Testing
Manually reviewed and confirmed the fallback now avoids reading an undefined
REMOTE_ADDRkey.Checklist