Fix flaky / failing tests.#29
Merged
Merged
Conversation
Update wp-env to fix unzip failing (WordPress/gutenberg#78762) Update src/Settings/Blocks/Fields/Checkboxes.php to fix PHP 8.5 tests Increase test timeout to 60s. wp-env sometimes takes longer to start and listen to requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes CI instability and PHP 8.5 compatibility issues affecting E2E tests.
1. wp-env CI failure after Node version change
GitHub Actions started failing due to a Node version change affecting
wp-envstartup behavior (see WordPress/gutenberg#78762).Fix: Updated
wp-envto restore compatibility.2. PHP 8.5 compatibility issue
Fixed compatibility issue in:
src/Settings/Blocks/Fields/Checkboxes.phpFix: Adjusted code to be compatible with PHP 8.5 changes.
3. Flaky E2E tests due to premature test execution
wp-env startdoes not guarantee WordPress is fully ready before tests run.Fix: Increased startup timeout to ensure WordPress is ready before executing tests.
Security implications
Testing
Checklist