Avoid callbacks when opening connection pools - #397
Closed
simolus3 wants to merge 4 commits into
Closed
Conversation
Owner
Author
|
Merged in f1cd435. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NativeCallableandPointer.fromFunctionare implemented by the Dart VM allocating an FFI stub in a page that is then remapped as executable. This is forbidden on some platforms like GrapheneOS.To avoid that issue, this splits the
pkg_sqlite3_connection_pool_openfunction into three parts:pkg_sqlite3_connection_pool_openlocks the global mutex of active pools and either returns a handle to the opened pool if it exists already, or indicates that the caller is responsible for initialization.pkg_sqlite3_connection_pool_initializetakes the role of what used to be a callback, turning an initialized pool into a pool client and unlocking.pkg_sqlite3_connection_pool_close_uninitializeddrops an uninitialized handle without creating a pool, used on exceptions.Closes #396.