LSR-38278: add pre-commit, yamllint, and GHA workflow#22
Open
artemantonenko-lshq wants to merge 1 commit into
Open
LSR-38278: add pre-commit, yamllint, and GHA workflow#22artemantonenko-lshq wants to merge 1 commit into
artemantonenko-lshq wants to merge 1 commit into
Conversation
shahriarshafiullah
approved these changes
Jun 24, 2026
shahriarshafiullah
left a comment
shahriarshafiullah
left a comment
There was a problem hiding this comment.
LGTM — standard LSR-38278 scaffold (pre-commit, yamllint, GHA workflow). No critical issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.pre-commit-config.yaml(created from template or amended in-place).yamllint.yaml.github/workflows/pre-commit.yml— runs pre-commit on every PRNext steps
Enable the
pre-commitstatus check as a required check underSettings → Branches → Branch protection rules for the default branch so
that merging is blocked until all hooks pass.
Warning
The following hooks were commented out in
.pre-commit-config.yamlbecause pre-commit kept failing after all auto-fix attempts. Search for# DISABLEDin the config to find them and re-enable once fixed:hadolint-docker