Skip to content

fix: fixed deps for better image rendering - #7

Merged
shibu0x merged 2 commits into
shibu0x:mainfrom
ifeelsam:main
Mar 7, 2026
Merged

fix: fixed deps for better image rendering#7
shibu0x merged 2 commits into
shibu0x:mainfrom
ifeelsam:main

Conversation

@ifeelsam

@ifeelsam ifeelsam commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

chore: update dependencies in Cargo.toml files

  • Updated viuer to version 0.11 in checkgit/Cargo.toml.
  • Updated image to version 0.25 in checkgit_core/Cargo.toml.
image

@shibu0x

shibu0x commented Mar 6, 2026

Copy link
Copy Markdown
Owner

thanks for the pr! i tested it on both ghostty and the default mac terminal. it renders the image clearly on ghostty, but the avatar appears distorted at the top in the normal mac terminal (without ghostty). could you please check if this can be fixed ?

image

@ifeelsam

ifeelsam commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

native macOS Terminal does not support inline image rendering, so can't fix that

@AvhiMaz

AvhiMaz commented Mar 7, 2026

Copy link
Copy Markdown
Collaborator

hi @ifeelsam thanks for the mr
image
but the image is still rendered as pixelated blocks on ghostty (i use ghostty). this is because probably viuer's detection doesn't recognize ghostty? with that said i want to know how you got a clear image?

i think the fix can be trying something like direct protocol implementation or handling TERM_PROGRAM=ghostty explicitly ?

@AvhiMaz AvhiMaz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update: i was on tmux, so the image was rendering pixelated. thanks, it works well now.

@ifeelsam

ifeelsam commented Mar 7, 2026

Copy link
Copy Markdown
Contributor Author

i pull the PR locally to check again, i checked both kitty, ghostty and also ran it in a vps, the image is rendering perfectly.
so i can't diagnose the issue unless i know how to replicate it, could you give me more info

image

@AvhiMaz

AvhiMaz commented Mar 7, 2026

Copy link
Copy Markdown
Collaborator

i pull the PR locally to check again, i checked both kitty, ghostty and also ran it in a vps, the image is rendering perfectly. so i can't diagnose the issue unless i know how to replicate it, could you give me more info

image

not an issue with ghostty, i was in tmux session that was causing the issue

@AvhiMaz

AvhiMaz commented Mar 7, 2026

Copy link
Copy Markdown
Collaborator

@ifeelsam there is a problem in the normal mac terminal.

image

at the top, some random gibberish characters are showing. not everyone will be using ghostty, so this might affect users who run it in the default Terminal.

could you please take a look? the goal is to make it ux better for all.

for more reference check at the top of the image there are some random numbers.
image

try running it in the normal terminal to reproduce the issue.

@ifeelsam

ifeelsam commented Mar 7, 2026

Copy link
Copy Markdown
Contributor Author

those aren't random gibberish characters, that's the Kitty graphics protocol escape sequence being printed as raw text because the macOS default Terminal app doesn't understand it.

so, i added the fix
Now in unsupported terminals (like macOS Terminal app), it'll fall back to block characters (▄) without leaking any raw escape sequences. In Kitty, Ghostty, or WezTerm it'll use the Kitty protocol, and in iTerm2 it'll use the iTerm protocol both giving full resolution images.

@shibu0x

shibu0x commented Mar 7, 2026

Copy link
Copy Markdown
Owner

thanks for the pr @ifeelsam !! lgtm 🤍

@shibu0x
shibu0x merged commit 5503b58 into shibu0x:main Mar 7, 2026
1 check failed
@ifeelsam

ifeelsam commented Mar 7, 2026

Copy link
Copy Markdown
Contributor Author

fix the build error in #8

@shibu0x

shibu0x commented Mar 7, 2026

Copy link
Copy Markdown
Owner

No worries! fixed it and pushed the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants