Skip to content

fix(config): drop redundant qwen3-8b-dta config and example#697

Open
curnane-lab wants to merge 3 commits into
sgl-project:mainfrom
curnane-lab:fix_issue_679
Open

fix(config): drop redundant qwen3-8b-dta config and example#697
curnane-lab wants to merge 3 commits into
sgl-project:mainfrom
curnane-lab:fix_issue_679

Conversation

@curnane-lab

@curnane-lab curnane-lab commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Motivation

As reported in #679, VP-Drafter support was removed in PR #660: 832263f dropped the training_mode/prefix_weight_base wiring in scripts/train_dflash.py, and fe0ad18 removed the remaining vp_drafter loss implementation from specforge/core/dflash.py. The two fields left in dflash_config of configs/qwen3-8b-dta.json are no longer read anywhere and are silently ignored, so training silently falls back to regular DFlash.

Without those dead fields, qwen3-8b-dta.json is byte-identical to configs/qwen3-8b-dflash.json. The config and examples/run_qwen3_8b_dta_online.sh were added together in 0b948e7 solely for the removed VP-Drafter training mode, so both are now redundant — keeping a duplicate config only risks future drift.

Modifications

  • Deleted configs/qwen3-8b-dta.json (a byte-identical duplicate of qwen3-8b-dflash.json once the dead fields are excluded).
  • Deleted examples/run_qwen3_8b_dta_online.sh (its only distinctive reference was the deleted config; the same training can be launched with --draft-config-path configs/qwen3-8b-dflash.json).

Related Issues

Fixes #679.

Accuracy Test

N/A — config/example cleanup, no model-side changes.

Benchmark & Profiling

N/A — no performance impact expected.

Checklist

  • Format your code according to the https://docs.sglang.ai/references/contribution_guide.html#code-formatting-with-pre-commit .
  • Add unit tests as outlined in the https://docs.sglang.ai/references/contribution_guide.html#running-unit-tests-adding-to-ci .
  • Update documentation / docstrings / example tutorials as needed, according to https://docs.sglang.ai/references/contribution_guide.html#writing-documentation-running-docs-ci .
  • Provide throughput / latency benchmark results and accuracy evaluation results as needed, according to https://docs.sglang.ai/references/benchmark_and_profiling.html and https://docs.sglang.ai/references/accuracy_evaluation.html .
  • For reviewers: If you haven't made any contributions to this PR and are only assisting with merging the main branch, please remove yourself as a co-author when merging the PR.
  • Please feel free to join our Slack channel at https://sgl-fru7574.slack.com/archives/C09784E3EN6 to discuss your PR.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@curnane-lab curnane-lab changed the title fix(config): remove stale vp_drafter fields from qwen3-8b-dta.json fix(config): remove stale vp_drafter fields Jul 17, 2026
VP-Drafter support was removed in sgl-project#660, leaving the
training_mode/prefix_weight_base fields in qwen3-8b-dta.json dead.
Without them the file is byte-identical to qwen3-8b-dflash.json,
and the example launcher only existed for the removed mode.
Drop both. Follow-up to sgl-project#660.
@curnane-lab curnane-lab changed the title fix(config): remove stale vp_drafter fields fix(config): drop redundant qwen3-8b-dta config and example Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vp_drafter is referenced in qwen3-8b-dta.json but is no longer supported by the training code

2 participants