fix(config): drop redundant qwen3-8b-dta config and example#697
Open
curnane-lab wants to merge 3 commits into
Open
fix(config): drop redundant qwen3-8b-dta config and example#697curnane-lab wants to merge 3 commits into
curnane-lab wants to merge 3 commits into
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
VP-Drafter support was removed in sgl-project#660, leaving the training_mode/prefix_weight_base fields in qwen3-8b-dta.json dead. Without them the file is byte-identical to qwen3-8b-dflash.json, and the example launcher only existed for the removed mode. Drop both. Follow-up to sgl-project#660.
curnane-lab
force-pushed
the
fix_issue_679
branch
from
July 17, 2026 04:37
ee4db26 to
c0018e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As reported in #679, VP-Drafter support was removed in PR #660: 832263f dropped the
training_mode/prefix_weight_basewiring inscripts/train_dflash.py, and fe0ad18 removed the remaining vp_drafter loss implementation fromspecforge/core/dflash.py. The two fields left indflash_configofconfigs/qwen3-8b-dta.jsonare no longer read anywhere and are silently ignored, so training silently falls back to regular DFlash.Without those dead fields,
qwen3-8b-dta.jsonis byte-identical toconfigs/qwen3-8b-dflash.json. The config andexamples/run_qwen3_8b_dta_online.shwere added together in 0b948e7 solely for the removed VP-Drafter training mode, so both are now redundant — keeping a duplicate config only risks future drift.Modifications
configs/qwen3-8b-dta.json(a byte-identical duplicate ofqwen3-8b-dflash.jsononce the dead fields are excluded).examples/run_qwen3_8b_dta_online.sh(its only distinctive reference was the deleted config; the same training can be launched with--draft-config-path configs/qwen3-8b-dflash.json).Related Issues
Fixes #679.
Accuracy Test
N/A — config/example cleanup, no model-side changes.
Benchmark & Profiling
N/A — no performance impact expected.
Checklist
https://docs.sglang.ai/references/contribution_guide.html#code-formatting-with-pre-commit.https://docs.sglang.ai/references/contribution_guide.html#running-unit-tests-adding-to-ci.https://docs.sglang.ai/references/contribution_guide.html#writing-documentation-running-docs-ci.https://docs.sglang.ai/references/benchmark_and_profiling.htmlandhttps://docs.sglang.ai/references/accuracy_evaluation.html.https://sgl-fru7574.slack.com/archives/C09784E3EN6to discuss your PR.