Close temporary rootmulti store in channel types setup#3690
Conversation
Close the rootmulti store created by TestTypesTestSuite once the proof fixture has been generated. The store starts asynchronous hash logger work during commit, and leaving it open can race with t.TempDir cleanup under the race-enabled CI job, causing flaky "directory not empty" cleanup failures in channel message validation tests.
PR SummaryLow Risk Overview The store can keep async hash-logger work running after Reviewed by Cursor Bugbot for commit aa360c9. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
There was a problem hiding this comment.
Small, correct test-only fix: the temporary rootmulti store is fully consumed within SetupTest (only suite.proof escapes), so deferring store.Close() there properly shuts down the async hash logger before t.TempDir cleanup, resolving the documented race-CI flake.
Findings: 0 blocking | 2 non-blocking | 0 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- Cursor's second-opinion review file (cursor-review.md) is empty — that pass produced no output.
- Codex's review reported no material findings (it could not run tests due to sandbox network restrictions, so no test verification was performed).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3690 +/- ##
==========================================
- Coverage 59.06% 58.34% -0.73%
==========================================
Files 2272 2185 -87
Lines 188193 178426 -9767
==========================================
- Hits 111162 104094 -7068
+ Misses 66979 65083 -1896
+ Partials 10052 9249 -803
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
* main: Add chain_id label to OTel metrics (#3692) Close temporary rootmulti store in channel types setup (#3690) Update changelog in prep to cut 6.6 RC1 (#3685) Pin priority-fee assertions to stable heads (#3680) Retry npm install for disable wasm integration test (#3674) State Store: Compact pruned key range after each prune (#3675)
Close the rootmulti store created by TestTypesTestSuite once the proof fixture has been generated. The store starts asynchronous hash logger work during commit, and leaving it open can race with t.TempDir cleanup under the race-enabled CI job, causing flaky "directory not empty" cleanup failures in channel message validation tests.
Flaked on main.