refactor(comms): set-based delivery-cursor seed for mandatory channels - #205
Open
seal-agent wants to merge 2 commits into
Open
refactor(comms): set-based delivery-cursor seed for mandatory channels#205seal-agent wants to merge 2 commits into
seal-agent wants to merge 2 commits into
Conversation
Collapse the two per-member seed N+1 loops (CreateChannel born-mandatory, SetChannelPolicy newly-mandatory) into one set-based INSERT ... SELECT each. A JOIN agent_accounts replaces the per-row WHERE EXISTS agent-only guard; the channel head is a same-channel constant computed once; ON CONFLICT DO NOTHING keeps re-subscribe idempotent. Byte-identical seed semantics (agent members only, seed-to-head, no replay) — a correctness-neutral parity cleanup surfaced by the SEA-1722 T4 review. The per-row seedDeliveryCursor helper is unchanged (still used by the membership-insert sites). Adds TestSetChannelPolicyMandatoryDoesNotSeedHumanMember pinning the JOIN's agent-only filter (a human member gets no cursor). Refs SEA-1836. Co-authored-by: Matt Wilkinson <matt@sealedsecurity.com>
Add a human member to TestCreateChannelBornMandatorySeedsCursors and assert it gets no delivery cursor after a born-mandatory create — symmetric with the SetChannelPolicy human-member test. Closes the review-flagged coverage gap: the set-based seed's agent-only JOIN was pinned only on the policy-flip path, not the create path (both reach the same helper, so this is coverage parity, not a fix). Refs SEA-1836. Co-authored-by: Matt Wilkinson <matt@sealedsecurity.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapse the two per-member seed N+1 loops (CreateChannel born-mandatory,
SetChannelPolicy newly-mandatory) into one set-based INSERT ... SELECT each.
A JOIN agent_accounts replaces the per-row WHERE EXISTS agent-only guard; the
channel head is a same-channel constant computed once; ON CONFLICT DO NOTHING
keeps re-subscribe idempotent. Byte-identical seed semantics (agent members
only, seed-to-head, no replay) — a correctness-neutral parity cleanup surfaced
by the SEA-1722 T4 review. The per-row seedDeliveryCursor helper is unchanged
(still used by the membership-insert sites).
Adds TestSetChannelPolicyMandatoryDoesNotSeedHumanMember pinning the JOIN's
agent-only filter (a human member gets no cursor).
Refs SEA-1836.
Co-authored-by: Matt Wilkinson matt@sealedsecurity.com