feat!: remove the callback-style submit() API - #12
Merged
Conversation
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 12, 2026
sderrow
force-pushed
the
sean/more-modernizations
branch
from
July 12, 2026 04:13
340bb4a to
5aa0ac5
Compare
sderrow
force-pushed
the
sean/remove-submit
branch
from
July 12, 2026 04:13
8a3f613 to
e0755c2
Compare
sderrow
marked this pull request as ready for review
July 12, 2026 04:15
sderrow
force-pushed
the
sean/more-modernizations
branch
from
July 12, 2026 04:23
5aa0ac5 to
f1b76e3
Compare
sderrow
force-pushed
the
sean/remove-submit
branch
from
July 12, 2026 04:23
e0755c2 to
135da4a
Compare
Owner
Author
sderrow
changed the base branch from
sean/more-modernizations
to
graphite-base/12
July 12, 2026 04:26
Bottleneck is Promise-only: schedule()/wrap() remain. Removes the submit method
sderrow
force-pushed
the
sean/remove-submit
branch
from
July 12, 2026 04:29
135da4a to
ca1c85e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Bottleneck is now Promise-only, as a reflection of modern JS.
schedule()andwrap()remain;submit()and theBottleneck.Callbacktype are gone.