Skip to content

Fix Install split_tests: gunzip -f to allow re-running in the same job - #18

Merged
scruplelesswizard merged 1 commit into
mainfrom
fix/gunzip-overwrite-existing-binary
Jul 31, 2026
Merged

Fix Install split_tests: gunzip -f to allow re-running in the same job#18
scruplelesswizard merged 1 commit into
mainfrom
fix/gunzip-overwrite-existing-binary

Conversation

@scruplelesswizard

Copy link
Copy Markdown
Owner

gunzip refuses to overwrite an existing output file without -f. That's fine calling this action once, but any workflow calling it more than once in the same job/workspace hits gzip: split_tests already exists; not overwritten (exit code 2) — which is exactly what #15's new smoke-test-correctness job does (invokes the action 3x to test 3 partitions). Regression from #12, which switched from curl | gunzip -v > split_tests (unconditional overwrite via shell redirection) to gunzip -v split_tests.gz (in-place, won't clobber by default). One-flag fix.

gunzip refuses to overwrite an existing output file without -f. That's
fine for a single invocation, but any workflow that calls this action
more than once in the same job/workspace (e.g. smoke-test-correctness
in #15, which calls it 3x to test 3 partitions) hit:

  gzip: split_tests already exists; not overwritten
  ##[error]Process completed with exit code 2

introduced when #12 switched from 'curl | gunzip -v > split_tests'
(unconditional overwrite via shell redirection) to 'gunzip -v
split_tests.gz' (in-place decompress, which gunzip won't clobber by
default).
@scruplelesswizard
scruplelesswizard merged commit f7c4fb4 into main Jul 31, 2026
11 checks passed
scruplelesswizard added a commit that referenced this pull request Jul 31, 2026
Adds smoke-test-correctness: runs the default file-count split across all three split-index values with split-total=3, then asserts partitions are non-empty, pairwise disjoint, and their union covers the full glob exactly. Closes the repo's own long-standing 'Test output for correctness' TODO. Its own CI run also caught two real regressions along the way (JUnit ruby-version bug from #6 -> fixed in #17; gunzip overwrite bug from #12 -> fixed in #18).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant