Fix Install split_tests: gunzip -f to allow re-running in the same job - #18
Merged
Merged
Conversation
gunzip refuses to overwrite an existing output file without -f. That's fine for a single invocation, but any workflow that calls this action more than once in the same job/workspace (e.g. smoke-test-correctness in #15, which calls it 3x to test 3 partitions) hit: gzip: split_tests already exists; not overwritten ##[error]Process completed with exit code 2 introduced when #12 switched from 'curl | gunzip -v > split_tests' (unconditional overwrite via shell redirection) to 'gunzip -v split_tests.gz' (in-place decompress, which gunzip won't clobber by default).
scruplelesswizard
added a commit
that referenced
this pull request
Jul 31, 2026
Adds smoke-test-correctness: runs the default file-count split across all three split-index values with split-total=3, then asserts partitions are non-empty, pairwise disjoint, and their union covers the full glob exactly. Closes the repo's own long-standing 'Test output for correctness' TODO. Its own CI run also caught two real regressions along the way (JUnit ruby-version bug from #6 -> fixed in #17; gunzip overwrite bug from #12 -> fixed in #18).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gunzip refuses to overwrite an existing output file without -f. That's fine calling this action once, but any workflow calling it more than once in the same job/workspace hits
gzip: split_tests already exists; not overwritten(exit code 2) — which is exactly what #15's new smoke-test-correctness job does (invokes the action 3x to test 3 partitions). Regression from #12, which switched fromcurl | gunzip -v > split_tests(unconditional overwrite via shell redirection) togunzip -v split_tests.gz(in-place, won't clobber by default). One-flag fix.