Fix Smoke Test JUnit: bump ruby-version 2.2 -> 3.2 - #17
Merged
Conversation
rspec_junit_formatter requires Ruby >= 2.3; the job pinned 2.2, so 'gem install rspec_junit_formatter' failed on every run. This has been broken on main since #6 merged (that PR was admin-merged with no CI run, so the break wasn't caught until this smoke test actually ran on a same-repo branch).
scruplelesswizard
added a commit
that referenced
this pull request
Jul 31, 2026
Adds smoke-test-correctness: runs the default file-count split across all three split-index values with split-total=3, then asserts partitions are non-empty, pairwise disjoint, and their union covers the full glob exactly. Closes the repo's own long-standing 'Test output for correctness' TODO. Its own CI run also caught two real regressions along the way (JUnit ruby-version bug from #6 -> fixed in #17; gunzip overwrite bug from #12 -> fixed in #18).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rspec_junit_formatterrequires Ruby >= 2.3; the job pinned 2.2, sogem install rspec_junit_formatterhas been failing on every run. This has been broken onmainsince #6 merged — that PR was admin-merged with no CI run (no checks ran at all on that fork PR), so the break wasn't caught until this job actually ran on a same-repo branch (in #15). One-line fix, same job otherwise unchanged.