Docs pass: fix stale README example, document Linux requirement - #14
Merged
Merged
Conversation
- Drop the deprecated GitHub Actions ::set-output syntax from the embedded example - it was fixed in the actual workflow files (#3) but the README's copy was never updated, so it was teaching new adopters a syntax GitHub has since removed. - Point the example at scruplelesswizard/split-tests@v1 instead of chaosaffe/split-tests@v1-alpha.1 (a stale pre-release tag under the repo's previous owner name; GitHub's redirect still resolves it, but the canonical name/tag should be what's documented). - Bump the embedded example's actions/checkout@v2 to @v4 to match #13. - Note the Linux-only runner requirement up front.
…le-and-linux-note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from REVIEW.adoc's Documentation section:
::set-outputsyntax from the embedded README example (the real workflow files were fixed in Replace deprecated set-output command #3, but the README's copy was never updated).scruplelesswizard/split-tests@v1instead of the stalechaosaffe/split-tests@v1-alpha.1(GitHub's rename-redirect still resolves the old owner name, but the canonical name/tag should be what's documented).actions/checkout@v2to@v4to match Bump actions/checkout from v2 to v4 in repo workflows #13.