feat: use Scribe-Data contract exports instead of hardcoded contracts - #70
Conversation
- updated `update_data.sh` to depend on whatever contracts available on the server - removed unwanted, hardcoded contract files from server
Thank you for the pull request! 💙The Scribe-Server team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
|
Hey @andrewtavis @axif0 With this PR, Scribe-Server no longer keeps its own hardcoded One unrelated thing bundled in: |
|
Do we need to load data into MariaDB for serving to the applications? @andrewtavis ? 🤔 |
|
As I understand it we do need the data to be in MariaDB in order for it to be sent by the API, @axif0 :) |
|
I agree @andrewtavis. We need to ensure that the updated data gotten from Scribe-Data is migrated into MariaDB in Toolforge. @axif0 could you buttress mores on your point, please? I believe I might be missing the point. BTW, I think we might need to update all our repos if we updated them to follow |
|
Let's maybe change the first issue message to thanking them for the issue and inviting them to join the Matrix, @DeleMike? I could see someone being confused be the email check message if they just open an issue. Also as that issue is mostly for maintainers :) Feel free to send along a message as described above if it makes sense to you! We can then move to finalize this after the discussion with @axif0 about MariaDB 😊 |
|
Feel free to open similar updates for the first contribution action in the other repos, @DeleMike! |
|
I will change the message then we can conclude this PR. Then I will take the accepted message into the other PRs. Thanks @andrewtavis |
andrewtavis
left a comment
There was a problem hiding this comment.
praise: All's looking great here, @DeleMike! So nice to have the issue in Scribe-Server finalize 😊 Now to finish Scribe-Data and bring it all together :) :)
|
Yes, feels nice too! We can now expand on it as the need arises! One thing I have always thought is improving the Scribe-Server Website, I think I will open a PR for that and we see how that goes. Should do this next week! :) |
|
Interested to see what you're thinking for the website, @DeleMike! :) |
Contributor checklist
./pre-commitexecutable as well asmake lintand have fixed all reported issuesDescription
Removes the hardcoded
contracts/directory from Scribe-Server. Data contracts are now exported fresh from Scribe-Data on every update run viascribe-data ec, so Scribe-Data remains the single source of truth for contracts and Scribe-Server no longer needs to keep its own copy in sync manually.update_data.sh, run right before filteringscribe-data fd) now always reads from the freshly exported directoryif [ ! -d "$CONTRACTS_DIR" ]fallback that skipped filtering when contracts were missing — contracts are now guaranteed to be present before filtering runsRelated issue