fix failing matrix notification workflow

[DeleMike]

Contributor checklist

• This pull request is on a separate branch and not the main branch
• I have ran the ./pre-commit executable as well as make lint and have fixed all reported issues

---

Description

Adds fixes to send information to Scribe-Data Channel

Related issue

• closes CI/CD: Matrix notifications failing during update_scribe_data workflow #67

[github-actions]

Thank you for the pull request! 💙🩵

The Scribe-Server team will do our best to address your contribution as soon as we can. The following are some important points:

• Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
• If you're not already a member of our public Matrix community, please consider joining!
  • We'd suggest that you use the Element client as well as Element X for a mobile app
  • Join the General and Data rooms once you're in
• Also consider attending our bi-weekly Saturday developer syncs!
  • Details are shared in the General room on Matrix each Wednesday before the sync
  • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

[github-actions]

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

• Tests for changes have been written and the continuous integration (CI) workflows within the PR checks do not indicate new errors in the files changed

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[DeleMike]

Hi @axif0, @andrewtavis, I was able to test sending notifications to my own created room successfully, as seen in the attached image.

However, because the Run update script (skips migration) takes like 40m on average, I cannot fully test it and more importantly, it only runs on the main branch, that is, after this is merged in.

How do we verify this workflow's success state? I have fixed it so that there is a success or failure state; it will send a notification to the Scribe-Data channel.

What do you think?

[DeleMike]

Hi @axif0, are we expecting anything here?

I am still figuring out how to verify the Matrix notification from the workflow. It works for my own account; I just need to see it in action via the workflow

[DeleMike]

I just confirmed the root cause with the exact Matrix error: M_UNKNOWN_TOKEN — "Token is not active". The bot's session itself has been logged out or expired.

Fix: We need to log in as the Scribe bot account and generate a brand-new access token, then update MATRIX_SCRIBE_BOT_ACCESS_TOKEN in repo Settings, then Secrets and variables, then Actions.

Also, the failure-notification path is broken the same way, but its || echo ... non-fatal fallback was hiding that from us; so we've had zero working Matrix notifications, not just the success ones.

Once rotated, we can trigger a manual workflow_dispatch run to confirm the new token gets a 200 back before relying on the scheduled monthly run.

See the new logs after merging the latest PR here:

@andrewtavis @axif0

[andrewtavis]

Thanks for checking this, @DeleMike! I'll look into this :)

[andrewtavis]

@DeleMike: I just updated MATRIX_SCRIBE_BOT_ACCESS_TOKEN. I didn't see an option to generate a new one, but the secret has been set to what Scribe Bots access token is. The only option in the settings is Clear cache and reload, and I did try that, but it's just for the session and doesn't change the access token.

[andrewtavis]

praise: All's looking good to me here, @DeleMike :) Let's give the new secret a try and see how we're doing 😊

[DeleMike]

Thanks @andrewtavis!✨