[essimaging] Orca normalization by proton charge per frame#663
Open
nvaytet wants to merge 5 commits into
Open
Conversation
…both sample and open beam, then divide by open beam
…at covers the whole experiment range
nvaytet
commented
Jul 1, 2026
| "ymir_lego_dark_run.hdf": "md5:c0ed089dd7663986042e29fb47514130", | ||
| "ymir_lego_openbeam_run.hdf": "md5:00375becd54d2ed3be096413dc30883c", | ||
| "ymir_lego_sample_run.hdf": "md5:ae56a335cf3d4e87ef090ec4e51da69c", | ||
| "ymir_lego_dark_run.hdf": "md5:2d9ae7d6f1d0502c17b0030bcb3dad1d", |
Member
Author
There was a problem hiding this comment.
I had to update the data because the proton charge in the old files started exactly at the start of the time axis for the camera data. However, when doing sc.lookup in 'previous' mode, the first data point was not found (probably because of numerical precision errors) and a NaN was returned.
So the first data slice in the dark lookup was NaN. We then took the mean which gave NaN, and then all data was NaN.
I now updated the proton charge logs to start a bit before the data starts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We change the way we use the proton charge to normalize the Orca data.
timedimension.(Sample - MeanDark) / (OpenBeam - MeanDark).mean('time')Fixes #636