removed version checks to tackle rrdtool pr #1331 - #23
Open
felixjogris wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the README to require a newer version of rrdtool and its perl module (RRDs). In mailgraph.cgi, it removes legacy version checks for RRDs, making the colon substitution in dates and the '--slope-mode' option unconditional, alongside a minor formatting fix. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This was referenced Jul 11, 2026
Open
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 30, 2026
See also: schweikert/mailgraph#23 PR: 296712 Approved by: maintainer timeout >2 weeks MFH: 2026Q3
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 30, 2026
See also: schweikert/mailgraph#23 PR: 296712 Approved by: maintainer timeout >2 weeks MFH: 2026Q3 (cherry picked from commit 84b6f5a)
dmytro-bilokha
pushed a commit
to dmytro-bilokha/freebsd-ports
that referenced
this pull request
Aug 13, 2026
See also: schweikert/mailgraph#23 PR: 296712 Approved by: maintainer timeout >2 weeks MFH: 2026Q3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest rrdtool now uses a new, fixed length minor version number. Please see oetiker/rrdtool-1.x#1331
Instead of complicated version checks, I'd like to require latest RRDs.pm released May 26, 2026, or later via the README file.