Build multi-destination replicationInfo per backend by maeldonn · Pull Request #6172 · scality/cloudserver

maeldonn · 2026-05-18T09:13:11Z

bert-e · 2026-05-18T09:13:16Z

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

codecov · 2026-05-18T09:20:18Z

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
9238	2	9236	0

View the full list of 2 ❄️ flaky test(s)

"after each" hook for "should fail if trying to overwrite a delete marker"::MPU with x-scal-s3-version-id header With default signature "after each" hook for "should fail if trying to overwrite a delete marker"

Flake rate in main: 100.00% (Passed 0 times, Failed 11 times)

Stack Traces | 0.017s run time

We encountered an internal error. Please try again.

"after each" hook for "should fail if trying to overwrite a delete marker"::MPU with x-scal-s3-version-id header With v4 signature "after each" hook for "should fail if trying to overwrite a delete marker"

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0.014s run time

We encountered an internal error. Please try again.

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

bert-e · 2026-05-20T14:51:36Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

claude · 2026-05-27T07:53:09Z

ReplicationConfiguration.resolveDestinationRole (line 166 of getReplicationInfo.js) does not exist in Arsenal — not in the pinned 8.4.2 tag, not on any branch, and not in any open PR across the scality org. This will crash at runtime for CRR backends and the unit tests referencing CRR destinations will also fail.
- Add a companion Arsenal PR with this method and bump the arsenal dependency, or implement the role-resolution logic inline.

Review by Claude Code

claude · 2026-05-28T15:24:25Z

Arsenal dependency not bumped: ReplicationConfiguration.resolveBackends and resolveSourceRole do not exist in arsenal 8.4.2. All 110 unit test failures are TypeError: ReplicationConfiguration.resolveBackends is not a function. Bump the arsenal dependency in package.json to a version that exports these static methods.
- Prettier check failing on all 4 changed files. Run prettier --write on them.

The refactoring logic itself (service-account gate extraction, default-storageClass helper, per-backend CRR/cloud handling in ACL flow) looks correct and well-tested, pending the arsenal dependency.

Review by Claude Code

bert-e · 2026-05-29T13:05:06Z

Conflict

There is a conflict between your branch improvement/CLDSRV-888/crr-multi and the
destination branch development/9.4.

Please resolve the conflict on the feature branch (improvement/CLDSRV-888/crr-multi).

git fetch && \
git checkout origin/improvement/CLDSRV-888/crr-multi && \
git merge origin/development/9.4

Resolve merge conflicts and commit

git push origin HEAD:improvement/CLDSRV-888/crr-multi

bert-e · 2026-06-05T15:56:50Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

claude · 2026-06-05T15:58:55Z

Arsenal is pinned to a commit hash (e4860ebc) instead of a tag, and the resolved version (8.4.3) is a downgrade from the previous 8.4.5. Pin to a proper tag once the arsenal changes are released.

Review by Claude Code

claude · 2026-06-05T16:20:33Z

Arsenal dependency is pinned to a raw commit hash instead of a tag, and yarn.lock shows a version downgrade from 8.4.5 to 8.4.3. Pin to a tagged release.

Review by Claude Code

claude · 2026-06-05T16:38:23Z

Arsenal dependency is pinned to a raw commit hash instead of a release tag. Git-based deps should pin to a tag for reproducibility and clarity.

Review by Claude Code

Issue: CLDSRV-888

claude · 2026-06-10T15:54:38Z

Arsenal is pinned to a commit hash instead of a tag in package.json.
- Pin to a tag (e.g. #8.x.x) per project convention for git-based deps.
- The ft_scripts npm script was removed from package.json, but .github/workflows/tests.yaml:635 still runs yarn run ft_scripts.
- Either remove the CI step or restore the script.

Review by Claude Code

claude · 2026-06-10T17:05:16Z

Arsenal dependency pinned to a commit hash instead of a tag (package.json line 40). Other git-based deps in the project use tags — pin to the tag that includes ReplicationConfiguration.resolveBackends/resolveSourceRole for consistency.

Review by Claude Code

claude · 2026-06-10T17:12:55Z

Arsenal dependency is pinned to a commit hash instead of a tag — should be tagged before merge

The refactoring to delegate rule-matching to arsenal's ReplicationConfiguration.resolveBackends looks clean. The service-account gate extraction, default storageClass fallback, and ACL replication logic (preserving cloud backend status while resetting CRR backends) are well-structured. The removed top-level fields (destination, storageClass, storageType, dataStoreVersionId) are not read by any other code in cloudserver, so the schema change is safe within this repo. Tests are thorough and cover V1/V2 format, dedup, mixed CRR+cloud, and edge cases.

Review by Claude Code

benzekrimaha · 2026-06-10T17:26:41Z

+                    }
+
+                    const existing = objectMD.replicationInfo.backends.find(e => e.site === b.site);
+                    return existing || b;


this still adds a newly configured cloud backend on an ACL-only update if there is also a CRR backend.
If cloud ACL replication is not supported, we should only preserve existing non-role backends, not add new ones as PENDING.
Maybe:

Suggested change

return existing || b;

const existing = objectMD.replicationInfo.backends.find(e => e.site === b.site);

return existing;

Good catch, switched to dropping newly configured cloud backends instead of adding them as PENDING, and matching existing entries by site + destination + role rather than site alone.

benzekrimaha · 2026-06-10T17:31:48Z

+        );
+    });
+
+    it('should add a newly configured CRR destination to backends on ' + 'putObjectACL', done => {


can we also have a test where a new cloud backend is added after the object was already replicated, then putObjectACL is called.
If ACL replication is not supported for cloud backends, that new cloud backend should not be added as PENDING.

Added, new test asserts a cloud destination added after replication is not added as PENDING on putObjectACL.

claude · 2026-06-11T11:52:59Z

Arsenal is pinned to a commit hash (724d062...) instead of a tag. Git-based deps must pin to a tag per project conventions.
- Pin to a released Arsenal tag (e.g. 8.4.6) once the required ReplicationConfiguration.resolveBackends and resolveSourceRole methods are included in a tagged release.

Review by Claude Code

claude · 2026-06-11T12:26:22Z

Arsenal dependency pinned to a raw commit hash instead of a tag (package.json:40). Previous value was #8.4.5; the new commit should be tagged before merging. - Pin to a proper tag for readability and consistency with the other git-based deps.

Review by Claude Code

benzekrimaha

LGTM on the replication logic now, arsenal is still pinned to a raw commit hash; this should wait for the Arsenal tag and pin to that tag before merge. Will we need a package version bump?

delthas

LGTM on the surface but need a 2nd pair of eyes from someone having worked on replication.

Match all enabled rules with the object's prefix (highest-priority wins on site collision) and stamp destination/role per CRR backend. Cloud backends get a bare entry — their bucket and credentials live in the location config. ACL replication uses per-backend `role` as the CRR marker so cloud backends keep their status. Legacy V1 and comma-separated `StorageClass` remain supported on read. Issue: CLDSRV-888

Issue: CLDSRV-888

claude · 2026-06-15T14:07:41Z

LGTM

The refactoring is clean: rule matching and backend stamping are correctly delegated to arsenal's ReplicationConfiguration.resolveBackends, the removed top-level fields (destination, storageClass, storageType, dataStoreVersionId) have no remaining consumers in production code, the ACL replication logic in acl.js properly distinguishes CRR (role-bearing) vs cloud backends, arsenal is pinned to tag 8.4.7, and the test coverage for the new multi-destination and mixed CRR/cloud scenarios is thorough.

Review by Claude Code

maeldonn · 2026-06-15T14:30:54Z

/approve

bert-e · 2026-06-15T14:31:34Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/9.4

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1
development/9.2
development/9.3

This pull request did not target the following hotfix branch(es) so they
were left untouched:

hotfix/6.4.7
hotfix/7.4.0
hotfix/9.0.32
hotfix/7.10.8
hotfix/7.10.0
hotfix/9.2.24
hotfix/7.4.3
hotfix/7.8.0
hotfix/7.10.3
hotfix/7.10.1
hotfix/7.4.10
hotfix/7.10.4
hotfix/7.4.9
hotfix/7.70.51
hotfix/7.70.21
hotfix/7.4.6
hotfix/7.4.7
hotfix/7.10.28
hotfix/7.6.0
hotfix/7.9.0
hotfix/7.4.1
hotfix/7.4.5
hotfix/7.10.27
hotfix/7.4.4
hotfix/7.4.8
hotfix/9.0.7
hotfix/7.2.0
hotfix/7.10.15
hotfix/7.10.49
hotfix/7.7.0
hotfix/7.70.11
hotfix/7.10.2
hotfix/7.4.2
hotfix/8.8.45
hotfix/7.70.73
hotfix/7.10.30
hotfix/7.70.45

Please check the status of the associated issue CLDSRV-888.

Goodbye maeldonn.

The following options are set: approve

scality deleted a comment from bert-e May 20, 2026

maeldonn force-pushed the improvement/CLDSRV-888/crr-multi branch from 545c4b6 to 0ff3941 Compare May 27, 2026 07:47

claude Bot reviewed May 27, 2026

View reviewed changes

Comment thread lib/api/apiUtils/object/getReplicationInfo.js Outdated

maeldonn force-pushed the improvement/CLDSRV-888/crr-multi branch from 0ff3941 to b98f98f Compare May 28, 2026 15:17

claude Bot reviewed May 28, 2026

View reviewed changes

Comment thread lib/api/apiUtils/object/getReplicationInfo.js

maeldonn requested review from a team, benzekrimaha and delthas May 29, 2026 08:58

maeldonn force-pushed the improvement/CLDSRV-888/crr-multi branch 4 times, most recently from e9693df to f98710c Compare June 5, 2026 15:56

claude Bot reviewed Jun 5, 2026

View reviewed changes