Skip to content

Credit oh-my-pi as the origin of the advisor design #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
salemsayed merged 1 commit into from
Aug 10, 2026
Merged

Credit oh-my-pi as the origin of the advisor design #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ reviewer runs in its own hidden thread with its own context, remembers what it
has already flagged, and escalates when the same defect comes back. A review
that cannot run reports as *unavailable*, never as approval.

Advisor is a bb port of the advisor from
[oh-my-pi](https://github.com/can1357/oh-my-pi) — the design is theirs. See
[Credits](#credits).

<p align="center">
<a href="https://cdn.jsdelivr.net/gh/salemsayed/bb-plugin-advisor@main/docs/media/advisor-promo.mp4"><strong>Play the 22-second demo →</strong></a>
<br />
Expand Down Expand Up @@ -278,6 +282,18 @@ npm pack --dry-run
The GitHub Actions workflow runs the same typecheck, test, build, and package
checks on pushes to `main` and on pull requests.

## Credits

The advisor concept — a persistent second model that reviews the primary
agent's work, holds findings across turns, and injects advice back into the
conversation — originates in [oh-my-pi](https://github.com/can1357/oh-my-pi)
by can1357. This plugin is a re-implementation of that design on bb's plugin
surface; the ideas are omp's, the bb-specific code is new.

[pi-omplike-advisor](https://github.com/pasky/pi-omplike-advisor) by pasky
ports the same design to upstream pi and is worth reading for its own take on
advice delivery and advisor context management.

## License

MIT © 2026 Salem Sayed Abdel Gawad. See [LICENSE](./LICENSE).