Fix Windows compatibility with hostnames containing a trailing label - #241
Merged
Conversation
complexspaces
force-pushed
the
verifier-trailing-labels-compat
branch
3 times, most recently
from
July 29, 2026 16:57
69698d5 to
d9f6352
Compare
complexspaces
force-pushed
the
verifier-trailing-labels-compat
branch
from
July 29, 2026 17:17
d9f6352 to
9f398bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a small incompatibility in the Windows verifier around hostnames which have a trailing
.in them that originates from the Win32 API itself.Other platforms do not appear to have the same limitation but I added the same stripping change everywhere to help keep the Rust layer of this library consistent cross-platform per its goals.
Closes #240